erikmav commented on code in PR #131:
URL: https://github.com/apache/logging-log4net/pull/131#discussion_r1541475884
##########
src/log4net/ILog.cs:
##########
@@ -216,7 +216,7 @@ public interface ILog : ILoggerWrapper
/// </remarks>
/// <seealso cref="M:Debug(object)"/>
/// <seealso cref="IsDebugEnabled"/>
- void DebugFormat(IFormatProvider provider, string format, params object[]
args);
+ void DebugFormat(IFormatProvider? provider, string format, params object[]
args);
Review Comment:
Also propagated new nulls for params like `object arg0` to align with this.
Leaving `object message` cases as non-nullable for now, but may need to flip
when trying 3.0 binaries in real projects with nullable turned on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
