ppkarwasz commented on PR #2442: URL: https://github.com/apache/logging-log4j2/pull/2442#issuecomment-2051291811
> Son of a gun, I forgot to hit submit so none of my comments have been viewable. It happens to me all the time or even I hit it, but a network problem prevents the comment from being posted. > To be clear, while I don't understand the purpose of this PR I am more disappointed with the mess ThreadContext (and ThreadContextMap in particular) has become with all these Map implementations, most of which are completely unnecessary simply by avoiding having to copy the map all the time as I have done in #2438. I agree the `ThreadContextMap` is a mess, with unnecessary abstractions (like `StringMap`), whose only purpose is to "give Java 7 users the Java 8 `Map#forEach` method today). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
