michaelbraun opened a new pull request, #2515: URL: https://github.com/apache/logging-log4j2/pull/2515
In a few places in code, DateTimeFormatter.format(...) is called on an Instant, which creates a new String, when this is just appended to a StringBuilder. This can be improved by calling DateTimeFormatter.formatTo, passing in the StringBuilder, resulting in no intermediate String. ## Checklist * Base your changes on `2.x` branch if you are targeting Log4j 2; use `main` otherwise * `./mvnw verify` succeeds (if it fails due to code formatting issues reported by Spotless, simply run `./mvnw spotless:apply` and retry) * Non-trivial changes contain an entry file in the `src/changelog/.2.x.x` directory * Tests for the changes are provided * [Commits are signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) (optional, but highly recommended) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
