alan0428a commented on PR #2691: URL: https://github.com/apache/logging-log4j2/pull/2691#issuecomment-2209669545
@vy Thanks for your feedback! Actually I am happy we have this careful reveiw process, so that we have high standard codes. Back to the topic, I also agree that this render logic should be in one place, since all renderer are doing similar things. But I am not sure if I unsderstand what `ThrowableProxy` really is and when it will be created in the `LogEvent`? I saw at `xxxThrowablePatternConverter#format()` we do conditions checking whether `event.getThrownProxy() is null`. But when will it be null? For `RootThrowablePatternConverter `, I think the passed in [ThrowableProxy](https://github.com/alan0428a/logging-log4j2/blob/42459ed966eaa728757e74d7dcfc0fb1953891ca/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/RootThrowablePatternConverter.java#L63) already has the root cause. Do we need to wrap it like what you mentioned? From the high level I guess I understand what we want to proceed, and I think it's a good resolution. Just there are some small questions may need your help to guide me here. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
