vy commented on code in PR #3045:
URL: https://github.com/apache/logging-log4j2/pull/3045#discussion_r1793337368
##########
log4j-core-test/src/test/java/org/apache/logging/log4j/core/impl/NestedLoggingFromThrowableMessageTest.java:
##########
@@ -80,14 +80,15 @@ public void testNestedLoggingInLastArgument() throws
Exception {
final Set<String> lines2 = readUniqueLines(file2);
assertEquals("Expected the same data from both appenders", lines1,
lines2);
- assertEquals(3, lines1.size());
+ assertEquals(2, lines1.size());
assertTrue(lines1.contains("INFO NestedLoggingFromThrowableMessageTest
Logging in getMessage "));
assertTrue(lines1.contains("ERROR
NestedLoggingFromThrowableMessageTest Test message"));
Review Comment:
Not really, since lines 2 and 3 get checked against their start, not the
complete content. Nevertheless, the situation is improved in
2022db7d3910bcd07b006452efc12e99482ca14c.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
