ppkarwasz commented on issue #2769:
URL: 
https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2461735723

   Hi @JWT007,
   
   > How many really create the `SocketPerformancePreferences` 
programmatically? :/
   
   IIRC, you are using the plugin builders quite a lot. Do you plan to also 
support `SocketPerformancePreferences`?
    
   > I think _if_ someone is creating a SocketPerformancePreferences 
programmatically they are doing it like this:
   > 
   > ```
   > SocketPerformancePreferences socketPerformancePreferences = 
SocketPerformancePreferences.newBuilder();
   > socketPerformancePreferences .setBandwidth(200);
   > socketPerformancePreferences .setConnectionTime(50);
   > socketPerformancePreferences.setLatency(5);
   > SocketPerformancePreferences clonedSPP = 
socketPerformancePreferences.build();
   > ```
   > 
   > In this case changing the return type would not really be a 
breaking-change because no one is currently _expecting_ a return type.
   
   The change will not break source compatibility, but binary compatibility 
will be broken and the code needs to be recompiled.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to