garydgregory commented on PR #3247: URL: https://github.com/apache/logging-log4j2/pull/3247#issuecomment-2525259755
> @garydgregory, > > Honestly I would prefer for the Jakarta JMS appender to work with the "JMS" name: as far as I understand now users need to change `JMS` to `JMS-Jakarta` in their Log4j Core 2 and to change from `JMS-Jakarta` back to `JMS` once they migrate to Log4j Core 3? Hi @ppkarwasz Ouch? For 2.x, reusing the "JMS" name will _force_ users to migrate from Javax to Jakarta, this is going to be a surprise hidden change and break existing configurations. I don't think we should do that. The move to 3.x will require plenty of changes for non-trivial configurations IMO, especially when switching from Javax to Jakarta, adding this and that new Log4j modules that are now split out. So I'm OK with keeping the new name, supporting both styles, or renaming. ATM, I am only concerns about an IRL 2.x use case for JMS and Jakarta. For 3.x we can do whatever. WDYT? > > Another question that we might want to discuss is the reliance on JNDI: the `JmsManager` actually only needs a JMS `ConnectionFactory` and it really doesn't matter how this factory is obtained. To configure JMS we could proceed the same way as with JDBC: > > * The `JMS-Jakarta` plugin could have a nested `ConnectionFactoryProvider` element to specify how to obtain the `ConnectionFactory`. > > * We provide an implementation of the `ConnectionFactoryProvider` implementation that uses JNDI. > > * Third parties (e.g. ActiveMQ Artemis) could provide other `ConnectionFactoryProvider`. I know that Spring Boot doesn't use JNDI at all with Artemis (see [`ArtemisConnectionFactoryConfiguration`](https://github.com/spring-projects/spring-boot/blob/main/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jms/artemis/ArtemisConnectionFactoryConfiguration.java)). > > > What do you think? Of course if there are configuration differences between the Javax and Jakarta JMS appenders, the name change is justified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
