jvz commented on code in PR #3333:
URL: https://github.com/apache/logging-log4j2/pull/3333#discussion_r1899696967
##########
src/site/antora/modules/ROOT/pages/faq.adoc:
##########
@@ -18,7 +18,7 @@ Licensed to the Apache Software Foundation (ASF) under one or
more
= F.A.Q.
This page compiles a list of frequently asked questions.
-If you don't find the answer to your question, please consult to
link:{logging-services-url}/support.html[the support page].
+If you don't find the answer to your question, please consult the
link:{logging-services-url}/support.html[the support page].
Review Comment:
```suggestion
If you don't find the answer to your question, please consult
link:{logging-services-url}/support.html[the support page].
```
"The" is repeated otherwise.
##########
src/site/antora/modules/ROOT/pages/faq.adoc:
##########
@@ -122,15 +122,15 @@ You can set the logging level on the `AppenderRef`
element.
. Make sure you have xref:manual/installation.adoc[the right JAR files] on
your classpath.
. Check the name of your configuration file.
-By default, Log4j looks for a configuration file named `log4j2.xml` on the
classpath.
+Log4j looks for a configuration file named `log4j2.xml` on the classpath by
default.
Note the `2` in the file name!
(See xref:manual/configuration.adoc[the Configuration page] for more details.)
. Increase the logging verbosity of the internal
xref:manual/status-logger.adoc[]: +
`-Dlog4j2.statusLoggerLevel=TRACE`
. Enable all internal debug logging: `-Dlog4j2.debug`.
-This disables level-based xref:manual/status-logger.adoc[] filtering and
effectively allows all status logs.
+This turns-off level-based xref:manual/status-logger.adoc[] filtering and
effectively allows all status logs.
Review Comment:
How about "This allows for all kinds of status log messages to be written"
or something like that.
##########
src/site/antora/modules/ROOT/pages/development.adoc:
##########
@@ -87,32 +87,32 @@ Pitch it in a
{logging-services-url}/support.html#discussions-maintainer[maintai
Go ahead and push it.
. Otherwise, submit a pull request.
-Make sure a changelog entry is attached and `./mvnw verify site` succeeds.
+Ensure a changelog entry is attached and `./mvnw verify site` succeeds.
+
[TIP]
====
-You are strongly advised to spar with another maintainer first (see
{logging-services-url}/support.html#discussions-maintainer[maintainer
discussion channels]) before starting to code.
+We strongly advise you to spar with another maintainer first (see
{logging-services-url}/support.html#discussions-maintainer[maintainer
discussion channels]) before starting to code.
Review Comment:
Is "spar" the right term here? I only know that in context of practice
martial arts fights (and apparently it's some part of a ship). I might go with
something like "discuss" here.
##########
src/site/antora/modules/ROOT/pages/development.adoc:
##########
@@ -54,7 +54,7 @@ The following branching scheme is followed:
`<sourceBranch>-site-<environment>`::
`<sourceBranch>-site-<environment>-out`::
Branches used to serve the staging and production websites.
-`out`-suffixed ones are automatically populated by CI, you are not supposed to
touch them.
+CI automatically populates `out`-suffixed ones; you are not supposed to touch
them.
Review Comment:
```suggestion
CI automatically populates `out`-suffixed branch names; you are not supposed
to touch them.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
