ViliusS commented on code in PR #3586:
URL: https://github.com/apache/logging-log4j2/pull/3586#discussion_r2024906218
##########
log4j-layout-template-json/src/main/resources/GcpLayout.json:
##########
@@ -49,25 +55,15 @@
"key": "span_id"
},
"logging.googleapis.com/trace_sampled": true,
- "_exception": {
- "class": {
- "$resolver": "exception",
- "field": "className"
- },
- "message": {
- "$resolver": "exception",
- "field": "message"
- },
- "stackTrace": {
- "$resolver": "pattern",
- "pattern": "%xEx"
- }
+ "exception": {
+ "$resolver": "pattern",
+ "pattern": "%xEx"
},
Review Comment:
I didn't find detailed reference for these fields, but that description in
documentation is confusing a bit. What they mean is that they check
`stack_trace` first, but they don't stop. They check all the fields present and
then if `message` field exist they just take stack trace from `message` field
ignoring all others.
At least this is how it worked for me during testing (I spent 2 hours trying
various stack trace formats and fields in real GCP environment).
I also tried to use `exception` resolver but it produces just a stack trace
without header and is not cought by Google Error Reporting. So in the end I
left `pattern` resolver like it was originally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
