swebb2066 commented on PR #495:
URL: https://github.com/apache/logging-log4cxx/pull/495#issuecomment-2814831567
To assist with the migration to the next ABI version, could you please also
test the LOG4CXX_ABI_VERSION. For example:
```
diff --git a/src/main/include/log4cxx/helpers/serversocket.h
b/src/main/include/log4cxx/helpers/serversocket.h
index dfc60d6c..683b4b8b 100644
--- a/src/main/include/log4cxx/helpers/serversocket.h
+++ b/src/main/include/log4cxx/helpers/serversocket.h
@@ -57,9 +57,12 @@ class LOG4CXX_EXPORT ServerSocket
*/
void setSoTimeout(int timeout);
+#if LOG4CXX_ABI_VERSION <= 15
static ServerSocketUniquePtr create(int port);
static ServerSocketUniquePtr create(int port, bool
reuseAddress);
-
+#else
+ static ServerSocketUniquePtr create(int port, bool
reuseAddress = false);
+#endif
};
} // namespace helpers
} // namespace log4cxx
diff --git a/src/main/include/log4cxx/private/aprserversocket.h
b/src/main/include/log4cxx/private/aprserversocket.h
index f8161a47..cea81256 100644
--- a/src/main/include/log4cxx/private/aprserversocket.h
+++ b/src/main/include/log4cxx/private/aprserversocket.h
@@ -31,8 +31,12 @@ namespace helpers
class LOG4CXX_EXPORT APRServerSocket : public helpers::ServerSocket
{
public:
+#if LOG4CXX_ABI_VERSION <= 15
APRServerSocket(int port);
APRServerSocket(int port, bool reuseAddress);
+#else
+ APRServerSocket(int port, bool reuseAddress = false);
+#endif
void close() override;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
