vy commented on code in PR #367:
URL: https://github.com/apache/logging-parent/pull/367#discussion_r2072430211
##########
.github/workflows/deploy-site-reusable.yaml:
##########
@@ -115,6 +105,12 @@ jobs:
git config user.name "ASF Logging Services RM"
git config user.email [email protected]
+ # Checking out a new branch will delete the `node_modules` folder
+ - name: Save Node.js modules
+ shell: bash
+ run: |
+ zip -qX "$RUNNER_TEMP"/node_modules.zip node_modules
Review Comment:
Shall we add `-0` to speed things up a bit?
##########
pom.xml:
##########
@@ -1576,6 +1575,10 @@
<goal>npm</goal>
</goals>
<phase>pre-site</phase>
+ <configuration>
+ <arguments>install
github:apache/logging-parent#feature/366-npm-shrinkwrap</arguments>
+ <!--<arguments>install
github:apache/logging-parent#rel/${stable-project.version}</arguments>-->
Review Comment:
I presume this will be fixed before merging this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
