swebb2066 commented on PR #502:
URL: https://github.com/apache/logging-log4cxx/pull/502#issuecomment-2957723767
Thanks for the fix.
To prevent future regressions, it may be advisable to include the
multiprocessrollingtest in a CI task by adding to a MacOs task:
```
diff --git a/.github/workflows/log4cxx-macos.yml
b/.github/workflows/log4cxx-macos.yml
index 21186763..55b56d23 100644
--- a/.github/workflows/log4cxx-macos.yml
+++ b/.github/workflows/log4cxx-macos.yml
@@ -31,16 +31,19 @@ jobs:
cxx: clang++
odbc: OFF
qt: ON
+ multiprocess: OFF
- name: osx-14
os: macos-14
cxx: clang++
odbc: ON
qt: OFF
+ multiprocess: ON
- name: osx-g++
os: macos-latest
cxx: g++-14
odbc: OFF
qt: OFF
+ multiprocess: OFF
steps:
- uses: actions/checkout@v4
@@ -59,7 +62,13 @@ jobs:
cd main
mkdir build
cd build
- cmake -DCMAKE_CXX_COMPILER=${{ matrix.cxx }}
-DLOG4CXX_ENABLE_ODBC=${{ matrix.odbc }} -DLOG4CXX_CFSTRING=ON
-DCMAKE_BUILD_TYPE=Debug ..
+ cmake \
+ -DCMAKE_CXX_COMPILER=${{ matrix.cxx }} \
+ -DLOG4CXX_ENABLE_ODBC=${{ matrix.odbc }} \
+ -DLOG4CXX_MULTIPROCESS_ROLLING_FILE_APPENDER=${{
matrix.multiprocess }} \
+ -DLOG4CXX_CFSTRING=ON \
+ -DCMAKE_BUILD_TYPE=Debug \
+ ..
cmake --build .
- name: run unit tests
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
