Flohack74 commented on code in PR #257:
URL: https://github.com/apache/logging-log4net/pull/257#discussion_r2164727735
##########
src/log4net/Appender/RollingFileAppender.cs:
##########
@@ -681,18 +681,16 @@ protected List<string> GetExistingFiles(string
baseFilePath)
using (SecurityContext?.Impersonate(this))
{
string fullPath = Path.GetFullPath(baseFilePath);
- string dir = Path.GetDirectoryName(baseFilePath);
directory = Path.GetDirectoryName(fullPath);
if (Directory.Exists(directory))
{
string baseFileName = Path.GetFileName(fullPath);
-
+
Review Comment:
You might want to clean that whitespace change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
