fluffynuts commented on code in PR #262:
URL: https://github.com/apache/logging-log4net/pull/262#discussion_r2182167909
##########
src/log4net/Appender/RollingFileAppender.cs:
##########
@@ -790,7 +790,7 @@ private void InitializeFromOneFile(string baseFile, string
curFileName)
curFileName = curFileName.ToLowerInvariant();
baseFile = baseFile.ToLowerInvariant();
string dir = string.IsNullOrEmpty(baseFile) ? "" :
Path.GetDirectoryName(baseFile);
- var baseFileWithoutExtension = Path.Combine(dir ?? "",
Path.GetFileNameWithoutExtension(baseFile));
+ string baseFileWithoutExtension = Path.Combine(dir ?? "",
Path.GetFileNameWithoutExtension(baseFile));
Review Comment:
is there a new style choice to prefer types over `var`? just curious - I see
that you prefer, eg,
```csharp
SomeType thing = new();
```
over
```csharp
var thing = new SomeType();
```
elsewhere - so perhaps this is just a habit :smile: not a big deal - just
curious
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
