vy opened a new issue, #3816: URL: https://github.com/apache/logging-log4j2/issues/3816
`InstantPatternLegacyFormatter` uses `InstantPatternDynamicFormatter` to determine the precision of the *legacy* date & time pattern it receives. As reported by @ppkarwasz (see [the review discussion](https://github.com/apache/logging-log4j2/pull/3789#discussion_r2197874778)), this results in incorrect precision (i.e., microseconds are currently classified as nanoseconds), and hence, causes incorrect cache invalidation. In 3799799ca77b1724e57214927d76ef0d1cff055a, @ppkarwasz fixes this by converting the legacy pattern back to `DateTimeFormatter`-compatible (i.e., modern) variant before passing it to `InstantPatternDynamicFormatter`. I am personally in favor of copying `InstantPatternDynamicFormatter::patternPrecision` to `InstantPatternLegacyFormatter`, and adapting it, since this will ensure legacy code remains an island. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
