swebb2066 commented on code in PR #511:
URL: https://github.com/apache/logging-log4cxx/pull/511#discussion_r2209109613


##########
src/examples/cpp/MyApp1.cpp:
##########
@@ -20,5 +20,6 @@ int main(int argc, char **argv) {
        LOG4CXX_INFO(logger, "Entering application.");
        foo();
        LOG4CXX_INFO(logger, "Exiting application.");
+       log4cxx::LogManager::shutdown();

Review Comment:
   > Most simple applications don't need it
   
   A simple application will morph into a more complex application (as in 
#510), so it is best to promote safe coding practices at the start.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to