garydgregory commented on PR #3855: URL: https://github.com/apache/logging-log4j2/pull/3855#issuecomment-3113058699
Hi all, TLDR: Let's bring this PR in and then... Let's not confuse file Appenders and file Managers ;-) I took a glance at the rolling file manager and it's a much larger code base. This PR is _small and focused_, which is a good thing. I am willing to volunteer to migrate the other manager code ((rolling) from IO to NIO _in a separate PR_ over the weekend probably, or at the very least initially from presenting `Path` instead/in addition to `String in the API. I can do this in a binary compatible way of course, but view is that these are internal classes up for breakage. So we'd need to agree on what kind of compatibility we want for `AbstractRolloverStrategy` and friends. This work would include https://github.com/apache/logging-log4j2/issues/2117. I want to think about the migration from IO to NIO in two steps: - PR 1: Migrate the API: Use Path where possible instead of String and File - PR 2: Migrate the implementation, there might be behavioral differences using `Files` that we only want to give users in 3.0 for example. WDYT? For 3.0, all bets are off and breaking BC is OK IMO in this area. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
