ppkarwasz commented on PR #3852:
URL: https://github.com/apache/logging-log4j2/pull/3852#issuecomment-3132981099

   > @ppkarwasz, while I do agree with you, the fix @rschmitt is proposing to 
the deprecated `createAppender` is already implemented for another deprecated 
`createAppender` just a few lines above. I'm inclined to accept @rschmitt's 
suggestion. WDYT?
   
   I am OK with the proposed patch, I was just wondering if we should also 
protect users that use `newBuilder().setTarget(null)` or we should throw a 
fail-fast NPE. I would rather prefer the second one.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to