ppkarwasz commented on issue #212: URL: https://github.com/apache/logging-log4j-transform/issues/212#issuecomment-3152582722
Hi @rschmitt, The generated JSON is technically valid, but you are right that pretty-printing (including proper indentation and a trailing newline) would significantly improve readability of the output We're currently using Jackson to serialize the configuration to JSON. Would you be willing to submit a PR to improve this? Specifically, you should look into [`JsonConfigurationMapper`](https://github.com/apache/logging-log4j-transform/blob/main/log4j-converter-config/src/main/java/org/apache/logging/converter/config/internal/v2/JsonConfigurationMapper.java) and configure Jackson to pretty-print the file. Also, it would be great to include a test to ensure that the output ends with a newline. On my side, I need to do some refactoring (see #214) to clean up the repository, after which I'm ready to cut a release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
