rm5248 commented on code in PR #524:
URL: https://github.com/apache/logging-log4cxx/pull/524#discussion_r2287818198
##########
src/site/markdown/configuration-samples.md:
##########
@@ -40,12 +40,57 @@ of [LoggerRepository](@ref log4cxx.spi.LoggerRepository).
To use automatic configuration with a non-standard file name
create and use your own wrapper for [getLogger](@ref
log4cxx.LogManager.getLogger).
-A full example can be seen in the \ref com/foo/config3.cpp file.
+A full example can be seen in the \ref com/foo/config4.cpp file.
+
+# Properties Files {#properties}
+
+Log4cxx may be configured using a Java properties (key=value) type file.
+
+The following is an example of a properties file.
+~~~
+# Uncomment a line to enable debugging for a category
+log4j.rootCategory=INFO, A1
+
+log4j.appender.A1=org.apache.log4j.RollingFileAppender
+log4j.appender.A1.MaxFileSize=5MB
+log4j.appender.A1.MaxBackupIndex=12
+log4j.appender.A1.File=${LocalAppData}/${CURRENT_VENDOR_FOLDER}/${CURRENT_PRODUCT_FOLDER}/Logs/${PROGRAM_FILE_PATH.STEM}.log
Review Comment:
I'd like it if we could have multiple examples for these files: with the
replacements(the new code you have in this PR) and one without(what exists
today). Especially if somebody is using an older version they might get
confused as to why the replacements aren't working.
Perhaps add something like:
```
As of version 1.6.0, Log4cxx can be configured with replacement values in
the configuration files. These allow you to make logs relative to the
executable location, not just the current working directory. The replacements
are documented <here>.
(example with replacements)
(example as it is today)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
