vy commented on code in PR #3901:
URL: https://github.com/apache/logging-log4j2/pull/3901#discussion_r2327289825
##########
log4j-layout-template-json-test/pom.xml:
##########
@@ -132,6 +132,13 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.elasticsearch.client</groupId>
+ <artifactId>elasticsearch-rest-client</artifactId>
Review Comment:
Can you implement the following changes, please?
1. Remove the `elasticsearch-java` dependency (We don't need this anymore,
right?)
2. Place the `elasticsearch-rest-client` dependency adhering to the
lexicographic order of artifact IDs
3. Replace hardcoded `<version>8...` with
`<version>${elastic.version}</version>`
##########
log4j-layout-template-json-test/pom.xml:
##########
@@ -189,6 +196,26 @@
<build>
<plugins>
+ <plugin>
Review Comment:
You don't need this plugin. You just need to add a [jdkToolchain] entry to
the `maven-failsafe-plugin` configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
