ppkarwasz commented on code in PR #3901:
URL: https://github.com/apache/logging-log4j2/pull/3901#discussion_r2339871919
##########
log4j-layout-template-json-test/pom.xml:
##########
@@ -84,15 +84,15 @@
</dependency>
<dependency>
- <groupId>org.awaitility</groupId>
- <artifactId>awaitility</artifactId>
+ <groupId>org.elasticsearch.client</groupId>
+ <artifactId>elasticsearch-rest-client</artifactId>
+ <version>${elastic.version}</version>
Review Comment:
Could you keep the test dependencies in alphabetical order by `artifactId`?
##########
log4j-layout-template-json-test/pom.xml:
##########
@@ -360,6 +360,10 @@
<log4j.logstash.gelf.port>${logstash.gelf.port}</log4j.logstash.gelf.port>
<log4j.logstash.tcp.port>${logstash.tcp.port}</log4j.logstash.tcp.port>
</systemPropertyVariables>
+ <jdkToolchain>
+ <version>17</version>
+ </jdkToolchain>
Review Comment:
I would drop this, since it requires all users to have Toolchains configured.
Since the default is to use the JVM running Maven and that one is already a
JDK 17, no toolchains are necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
