ppkarwasz opened a new pull request, #3932: URL: https://github.com/apache/logging-log4j2/pull/3932
This PR fixes edge cases involving the apostrophe (`'`) in pattern literals. Previously, certain inputs produced unintended escaped apostrophes (`''`) at fragment boundaries or misinterpreted doubled quotes inside quoted blocks. ## What’s changed * **Parsing:** Correctly interprets `''` as a literal apostrophe **inside** quoted sections. * **Merging:** When concatenating pattern fragments, if the left ends with `'` and the right starts with `'`, we now drop the left closing quote and the right opening quote to keep a single continuous quoted block, avoiding an unintended literal `''`. * **Tests:** Added comprehensive cases covering parsing and boundary merges. ## Rationale `DateTimeFormatter` uses `'...'` to denote literals and `''` to escape a literal apostrophe. When two quoted literal blocks are concatenated naïvely, a `...''...` boundary can be produced, which `DateTimeFormatter` reads as a **literal apostrophe**, not close+open delimiters. Closes #3930. ## Checklist Before we can review and merge your changes, please go through the checklist below. If you're still working on some items, feel free to submit your pull request as a draft—our CI will help guide you through the remaining steps. ### ✅ Required checks - [x] **License**: I confirm that my changes are submitted under the [Apache License, Version 2.0](https://apache.org/licenses/LICENSE-2.0). - [x] **Commit signatures**: All commits are signed and verifiable. (See [GitHub Docs on Commit Signature Verification](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)). - [x] **Code formatting**: The code is formatted according to the project’s style guide. <details> <summary>How to check and fix formatting</summary> - To **check** formatting: `./mvnw spotless:check` - To **fix** formatting: `./mvnw spotless:apply` See [the build instructions](https://logging.apache.org/log4j/2.x/development.html#building) for details. </details> - [x] **Build & Test**: I verified that the project builds and all unit tests pass. <details> <summary>How to build the project</summary> Run: `./mvnw verify` See [the build instructions](https://logging.apache.org/log4j/2.x/development.html#building) for details. </details> ### 🧪 Tests (select one) - [x] I have added or updated tests to cover my changes. - [ ] No additional tests are needed for this change. ### 📝 Changelog (select one) - [x] I added a changelog entry in `src/changelog/.2.x.x`. (See [Changelog Entry File Guide](https://logging.apache.org/log4j/tools/log4j-changelog.html#changelog-entry-file)). - [ ] This is a trivial change and does not require a changelog entry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
