vy commented on code in PR #3934:
URL: https://github.com/apache/logging-log4j2/pull/3934#discussion_r2381693640
##########
log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/db/AbstractDatabaseManagerTest.java:
##########
Review Comment:
AFAICT these changes are unrelated. If so, would you mind reverting them,
please? If so, would you mind explaining the rationale, please?
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ThrowableStackTraceRenderer.java:
##########
@@ -268,9 +268,15 @@ static final class Metadata {
*/
final int stackLength;
- private Metadata(final int commonElementCount, final int
stackLength) {
+ /**
+ * The suppressed exceptions attached to this {@link Throwable}
Review Comment:
```suggestion
* The suppressed exceptions attached to this {@link Throwable}.
* This needs to be captured separately since {@link
Throwable#getSuppressed()} can change.
*
* @see <a
href="https://github.com/apache/logging-log4j2/issues/3929";>#3929</a>
* @see <a
href="https://github.com/apache/logging-log4j2/pull/3934";>#3934</a>
```
##########
log4j-core-test/pom.xml:
##########
@@ -347,6 +347,12 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-inline</artifactId>
+ <scope>test</scope>
+ </dependency>
+
Review Comment:
Why do we need this?
##########
log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/db/AbstractDatabaseAppenderTest.java:
##########
Review Comment:
AFAICT these changes are unrelated. If so, would you mind reverting them,
please? If so, would you mind explaining the rationale, please?
##########
log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/rolling/RandomRollingAppenderOnStartupTest.java:
##########
Review Comment:
AFAICT these changes are unrelated. If so, would you mind reverting them,
please? If so, would you mind explaining the rationale, please?
##########
src/changelog/2.25.1/3929_ThrowableStackTraceRenderer-npe.xml:
##########
@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<entry xmlns="https://logging.apache.org/xml/ns";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="
+ https://logging.apache.org/xml/ns
+ https://logging.apache.org/xml/ns/log4j-changelog-0.xsd";
+ type="fixed">
+ <issue id="3929"
link="https://github.com/apache/logging-log4j2/issues/3929"/>
Review Comment:
```suggestion
<issue id="3929"
link="https://github.com/apache/logging-log4j2/issues/3929"/>
<issue id="3934"
link="https://github.com/apache/logging-log4j2/pull/3934"/>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
