swebb2066 commented on code in PR #548: URL: https://github.com/apache/logging-log4cxx/pull/548#discussion_r2396320445
########## src/test/cpp/asyncappendertestcase.cpp: ########## Review Comment: > since the macro changes from LOG4CXX_DEBUG to LOG4CXX_DEBUG_ASYNC This PR introduces a new macro that a user must opt-in to use. Some instances of LOG4CXX_DEBUG will not work if the user changes it to LOG4CXX_DEBUG_ASYNC (e.g. non copy-constructable values, using `L"Some wide char string"` as the first message value when `logchar` is `char`). > I would be worried about breaking existing code if we don't keep the current tests as-is. The tests `closeTest`, `test2` and `testBadAppender` use non-async logging methods. Mixing non-async and async logging is perfectly safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
