vy commented on code in PR #3953: URL: https://github.com/apache/logging-log4j2/pull/3953#discussion_r2423094798
########## src/changelog/.2.x.x/3947_fix_SslSocketManager_null_keystore.xml: ########## @@ -0,0 +1,14 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns="https://logging.apache.org/xml/ns"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation=" + https://logging.apache.org/xml/ns + https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"; + type="fixed"> + <issue id="3947" link="https://github.com/apache/logging-log4j2/issues/3947"/> + <description format="asciidoc"> + Corrected nullability annotations in `SslConfiguration` which lead to nullability problems in consuming code. + In particular, when configuring a syslog appender, if only a truststore is defined, an exception is thrown during configuration time. + This fixes that error along with various other potential null errors in related code. Review Comment: Let's keep the release notes short. Interested parties can refer to Issue & PR for details. ```suggestion <issue id="3947" link="https://github.com/apache/logging-log4j2/issues/3947"/> <issue id="3953" link="https://github.com/apache/logging-log4j2/pull/3953"/> <description format="asciidoc"> Fix failures caused by null `SslConfiguration` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
