SpaceLeam commented on PR #97: URL: https://github.com/apache/logging-log4j-scala/pull/97#issuecomment-3693158567
<img width="1366" height="768" alt="Screenshot_2025-12-26_12_42_35" src="https://github.com/user-attachments/assets/0eb836d8-efdb-483e-b49e-c672f0a60c8e"; /> <img width="1366" height="768" alt="Screenshot_2025-12-26_12_42_26" src="https://github.com/user-attachments/assets/bf3741e0-5c7a-46bd-96fa-08be2eb60207"; /> --- **Status Update: Ready for Merge** @vy I have completed all the requested changes. **Summary of Changes:** * **Code:** Implemented `LoggingContext.withContext` (Loan Pattern) across all modules. * Used `scala.jdk.CollectionConverters` for Scala 2.13+. * Used `scala.collection.JavaConverters` for Scala 2.10/2.11/2.12 to maintain backward compatibility. * **Documentation:** * Added `@since 13.2.0` tags. * Fixed JavaDoc formatting (used `{@link}`). * Updated `src/site/antora/modules/ROOT/pages/index.adoc` with the usage example. * **Changelog:** Added the XML entry in `src/changelog/.13.x.x` linked to issue #97. * **Testing:** Added `test("withContext")` to `LoggingContextTest.scala`. **Verification:** I ran `./mvnw test` locally to ensure stability (see screenshot below). **Passed:** `log4j-api-scala_2.12` and `log4j-api-scala_2.13` compiled and passed all tests successfully. **Note:** The CI checks are failing/pending due to infrastructure issues unrelated to these changes. My local build confirms the logic is sound. The PR is updated and ready for review. --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
