rm5248 commented on code in PR #593:
URL: https://github.com/apache/logging-log4cxx/pull/593#discussion_r2795899860
##########
src/main/cpp/formattinginfo.cpp:
##########
@@ -79,7 +79,9 @@ FormattingInfoPtr FormattingInfo::getDefault()
*/
void FormattingInfo::format(const int fieldStart, LogString& buffer) const
{
- int rawLength = int(buffer.length() - fieldStart);
+ if (INT_MAX < buffer.length())
Review Comment:
wait no I'm misreading it, nevermind. The comparison is backwards from what
I would typically do(`if buffer.length() > INT_MAX`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
