swebb2066 commented on code in PR #625:
URL: https://github.com/apache/logging-log4cxx/pull/625#discussion_r3042441236
##########
src/main/include/log4cxx/helpers/bytebuffer.h:
##########
@@ -28,31 +28,82 @@ namespace helpers
{
/**
-* A byte buffer.
+* An area of memory, a cursor into that memory and a count of remaining bytes.
+* It does not own the memory, so does not allocate or free memory.
+* The user must ensure the lifetime of the memory exceeds the lifeime of the
class instance.
*/
class LOG4CXX_EXPORT ByteBuffer
Review Comment:
ByteBuffer has the extra functionality of a cursor, so std::span is not a
drop in replacement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
