swebb2066 commented on code in PR #636:
URL: https://github.com/apache/logging-log4cxx/pull/636#discussion_r3140875262
##########
src/main/include/log4cxx/spi/optionhandler.h:
##########
@@ -43,19 +43,23 @@ class LOG4CXX_EXPORT OptionHandler : public virtual
helpers::Object
<p>This allows to defer activiation of the options until all
options have been set. This is required for components which
have
- related options that remain ambigous until all are set.
+ related options that remain ambiguous until all are set.
<p>For example, the FileAppender has
the <code>File</code> and <b>Append</b> options both of
- which are ambigous until the other is also set.
+ which are ambiguous until the other is also set.
*/
#if LOG4CXX_ABI_VERSION <= 15
+#define LOG4CXX_ACTIVATE_OPTIONS_FORMAL_PARAMETERS helpers::Pool& p
Review Comment:
Yes, when switching to the new ABI, conditional sections can be resolved
using [my Boost Wave-based program](https://github.com/swebb2066/cpp-resolve)
or [unifdef](https://linux.die.net/man/1/unifdef) and the ABI version-dependant
macros (LOG4CXX_ACTIVATE_OPTIONS_FORMAL_PARAMETERS,
LOG4CXX_ACTIVATE_OPTIONS_PARAMETER and LOG4CXX_16_VIRTUAL_SPECIFIER)
substituted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
