gdziadkiewicz commented on issue #292: URL: https://github.com/apache/logging-log4net/issues/292#issuecomment-4324605123
Hi, I spent some time on it. Log4net 2.x avoids the issue by heavy lock usage. The locks got removed in version 3 and opened this bag of challenges. I drafted a solution that does not reintroduce the locking, but instead introduces a bool carried with each logger for tracking its readiness (only one thread wins the competition for creating the missing logger, rest wait until it is done, similar to 2.x behavior, but none of the global locking). Immediately the imaginary friend noted that there are two open questions: 1. What to do with the `OnLoggerCreation` event? Is completing the callback a requirement to be "ready"? User can register whatever they want for callback. I'm tempted to recreate 2.x behavior there. 2. I only addressed dot-less loggers. I should extend the tests to also tests dotted loggers that are more connected in the hierarchy . I will do that and make sure the fix also addresses them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
