swebb2066 commented on code in PR #652:
URL: https://github.com/apache/logging-log4cxx/pull/652#discussion_r3212178015


##########
src/main/cpp/visualstudio.natvis:
##########


Review Comment:
   > Should it be in the repo in the first place?
   
   Absolutely. It allows developers to immediately see the values of all the 
attributes of the derived (private) structs in the Visual Studio debugger. It 
is included in the CMakeLists files for WIN32.
   ```
   if(WIN32)
     target_sources(log4cxx
       PRIVATE visualstudio.natvis
     )
   endif(WIN32)
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to