ramanathan1504 opened a new pull request, #4119: URL: https://github.com/apache/logging-log4j2/pull/4119
Fixes #3086 This pull request refactors the `RegexFilter` to use a plugin builder pattern, restores support for configuring regex `patternFlags` via a comma-separated attribute, and improves robustness around the `useRawMsg` option. It also adds tests and documentation for the new pattern flags feature. **RegexFilter Refactor and Feature Restoration:** * Refactored `RegexFilter` to use a plugin builder (`Builder` class), simplifying construction and improving maintainability. The builder now uses a primitive boolean for `useRawMsg` to avoid null-unboxing issues. [[1]](diffhunk://#diff-240d93e5d49d2cce79e7ba0c5f0c78a5048288d3a122556b5dae7c9d81907d2dR119-R123) [[2]](diffhunk://#diff-240d93e5d49d2cce79e7ba0c5f0c78a5048288d3a122556b5dae7c9d81907d2dL133-L175) * Restored and improved support for configurable regex `patternFlags` via a comma-separated string attribute (e.g., `patternFlags="CASE_INSENSITIVE"`), replacing the previous, more cumbersome approach. **Testing Improvements:** * Added a new test (`testPatternFlagsFromConfiguration`) in `RegexFilterTest.java` to verify that pattern flags are correctly loaded from configuration files. * Added a corresponding test configuration file `RegexFilterPatternFlagsTest.xml` to exercise the new pattern flags feature. **Documentation and Changelog:** * Updated the manual to document the `patternFlags` attribute, listing all supported flag values and usage. * Added a changelog entry describing the refactor, restoration of `patternFlags`, and the builder improvements. **Other:** * Bumped the OSGi version for the filter package to `2.26.0` to reflect the new feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
