ramanathan1504 commented on code in PR #4119:
URL: https://github.com/apache/logging-log4j2/pull/4119#discussion_r3335690775
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/filter/RegexFilter.java:
##########
@@ -130,48 +135,100 @@ public String toString() {
* @param mismatch
* The action to perform when a mismatch occurs.
* @return The RegexFilter.
- * @throws IllegalAccessException When there is no access to the
definition of the specified member.
- * @throws IllegalArgumentException When passed an illegal or
inappropriate argument.
*/
- // TODO Consider refactoring to use AbstractFilter.AbstractFilterBuilder
- @PluginFactory
public static RegexFilter createFilter(
// @formatter:off
@PluginAttribute("regex") final String regex,
- @PluginElement("PatternFlags") final String[] patternFlags,
+ @PluginAttribute("patternFlags") final String[] patternFlags,
Review Comment:
@vy, Yes, I also verified that this introduces a breaking change.
What would be the preferred approach here? Should we add OSGi/bnd versioning
support for backward compatibility, or should we hold this change for the next
major version? Another option would be to restore backward compatibility by
supporting both the old and new configuration formats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
