ramanathan1504 commented on code in PR #4070:
URL: https://github.com/apache/logging-log4j2/pull/4070#discussion_r3418020858
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/impl/Log4jContextFactory.java:
##########
@@ -300,10 +300,16 @@ public LoggerContext getContext(
final boolean currentContext,
final List<URI> configLocations,
final String name) {
- final LoggerContext ctx =
- selector.getContext(fqcn, loader, currentContext, null /*this
probably needs to change*/);
- if (externalContext != null && ctx.getExternalContext() == null) {
- ctx.setExternalContext(externalContext);
+ final LoggerContext ctx;
+ if (externalContext instanceof Map.Entry) {
Review Comment:
@rgoers, following discussions with @vy and @ppkarwasz, we have aligned on a
Map-backed refactor to resolve the collision issue you raised. I have updated
the PR title and description accordingly. This approach maintains backward
compatibility for Spring Boot while providing a clean fix for the composite
configuration issue. Resolving this conversation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
