vy commented on PR #4144: URL: https://github.com/apache/logging-log4j2/pull/4144#issuecomment-4807288142
> > * Adding a new dependency for a feature that is used by a majority of the user base (i.e., XML-based configuration) can break fat-JAR setups. > > I do not yet see the failure mode. An uber-JAR absorbs its dependencies by design, so one more compile-scope dependency is shaded in like any other. @ppkarwasz, it breaks setups of users populating their `lib` folder with JARs manually. Furthermore, logging implementations (not APIs) by nature are provided to the class path in the last mile: when it is getting deployed. This can even be a deployment script: `java -cp log4j-core.jar:app.jar -Dlog4j2.configurationFile=/etc/log4j.xml com.acme.App` Both of these user groups will observe a failure due to any new transitive dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
