ramanathan1504 commented on PR #4156:
URL: https://github.com/apache/logging-log4j2/pull/4156#issuecomment-5129297976
Full reactor build is green across all 27 modules with zero setter
violations, and spotless is clean — both my earlier points are fixed. Nice
catch on the `withXxx` guard too; 2.x only checks `startsWith("set")`, so its
`with` branch is dead code.
One blocker: the new test leaves `example/` and a `PluginService` file in
the module directory. The `@AfterEach` deletes `Log4j2Plugins.dat` — that's the
2.x artifact name, it doesn't exist in 3.x — so it cleans up a file that's
never created and misses the two that are. A `@TempDir` output path fixes it.
Also worth a look: adding `PluginBuilderAttribute` to
`@SupportedAnnotationTypes` isn't needed — 2.x resolves it with
`getTypeElement()` inside `process()`, and `internal/Annotations.java` already
owns both FQNs. And the `StringMatchFilter` suppression collides with #4153,
which renames that setter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
