vpelikh commented on PR #4156: URL: https://github.com/apache/logging-log4j2/pull/4156#issuecomment-5340837687
Thanks for the review, @ramanathan1504! I’ve addressed all three points: 1. StringMatchFilter — Kept the @SuppressWarnings here with a // Remove once #4153 renames the setter to match the field name comment, so neither PR depends on the other’s merge order. #4153 can drop it in the same hunk when it merges. 2. Rfc5424Layout — Good catch, that was exactly the gap the processor is meant to find. I ported the fluent setEnterpriseNumber(Integer) setter over from 2.x and removed the suppression instead of hiding it. 3. Tests — Added assertThat(errorDiagnostics).hasSize(1) to all three cases so they fail if the processor is absent, not just when the specific message is absent. Thanks again for the thorough review and for staying patient! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
