SebTardif commented on PR #4218: URL: https://github.com/apache/logging-log4j2/pull/4218#issuecomment-5281101883
@vy Follow-ups from your review are on the tip (`b323bff7`): 1. File branch uses `Files.newInputStream(configFile.toPath())`. 2. Closed-stream proof no longer depends on FD counts or deleting the config file. A test `ConfigurationFactory` captures `source.getInputStream()` without consuming it; after `setConfigLocationUri` returns, reading from that stream throws (stream closed). Could you take another look when you have a moment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
