ramanathan1504 commented on PR #4186: URL: https://github.com/apache/logging-log4j2/pull/4186#issuecomment-5440452914
@ppkarwasz reworked to the `literal` grammar @vy proposed on the issue, both your comments are still in — the sets are `Collections.emptySet()` when absent with `@NonNull` on the fields, and the benchmark compares two full layouts: `4.562` vs `1.833 ops/us`. A mis-shaped `literal` now throws the way `flatten` does, but a typo'd sub-key (`disalowed`) still parses and silently filters nothing — worth rejecting unknown keys under `literal`, or leave it as is? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
