vy commented on code in PR #4186:
URL: https://github.com/apache/logging-log4j2/pull/4186#discussion_r3914140207
##########
log4j-layout-template-json/src/main/resources/EcsLayout.json:
##########
@@ -26,7 +26,19 @@
"labels": {
"$resolver": "mdc",
"flatten": true,
- "stringified": true
+ "stringified": true,
+ "literal": {
+ "disallowed": [
+ "@timestamp",
+ "message",
+ "log.logger",
+ "log.level",
+ "event.dataset",
+ "process.thread.name",
+ "process.thread.id",
+ "ecs.version"
+ ]
+ }
Review Comment:
I'd not use the word `filter`, it doesn't match what we already have: `key`
and `pattern`, which both "filter".
@ramanathan1504, we had an internal conversation with @ppkarwasz, and
[agreed] to overload `key` instead. That is, if `key` is of type string, use
the existing behavior, if it is of type object, use the new semantics with
`allowed`/`disallowed`. Would you mind updating the PR in that direction,
please?
[agreed]:
https://the-asf.slack.com/archives/D0394M6GWTX/p1788351977612879?thread_ts=1788344568.252929&cid=D0394M6GWTX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
