swebb2066 opened a new pull request, #746: URL: https://github.com/apache/logging-log4cxx/pull/746
This PR fixes the following catastrophic performance degradation caused by the use of std::call_once in commit 2dc44dc. Comparing commit_acaf388_benchmark.json to commit_2dc44dc_benchmark.json | Benchmark | Time | CPU | Time Old | Time New | | ------------ | ------ | ---- | ----------- | ----------- | | Testing disabled logging request | -0.0052 | -0.0052 | 0 | 0| | Testing disabled logging request/threads:6 | +0.0211 | +0.0211 | 0 | 0| | Appending 5 char string using MessageBuffer, pattern: %m%n | +1.3364 | +1.3364 | 360 | 840| | Appending 5 char string using MessageBuffer, pattern: %m%n/threads:6 | +1.8875 | +0.8603 | 573 | 1656| | Appending 49 char string using MessageBuffer, pattern: %m%n | +1.2600 | +1.2601 | 390 | 882| | Appending 49 char string using MessageBuffer, pattern: %m%n/threads:6 | +1.5799 | +0.5670 | 653 | 1686| | Appending int value using MessageBuffer, pattern: %m%n | +0.8815 | +0.8815 | 542 | 1019| | Appending int value using MessageBuffer, pattern: %m%n/threads:6 | +1.5328 | +0.4836 | 695 | 1760| | Appending int+float using MessageBuffer, pattern: %m%n | +0.5231 | +0.5232 | 973 | 1483| | Appending int+float using MessageBuffer, pattern: %m%n/threads:6 | +1.4483 | +0.5422 | 968 | 2370| | Appending int+10float using MessageBuffer, pattern: %m%n | +0.0165 | +0.0165 | 4787 | 4866| | Appending int+10float using MessageBuffer, pattern: %m%n/threads:6 | +0.0010 | +0.0017 | 2036 | 2038| | Appending int value using MessageBuffer, pattern: [%d] %m%n | +0.8675 | +0.8676 | 637 | 1190| | Appending int value using MessageBuffer, pattern: [%d] [%c] [%p] %m%n | +0.7394 | +0.7394 | 770 | 1340| | Appending 49 char string using FMT, pattern: %m%n | +1.3553 | +1.3554 | 373 | 879| | Appending 49 char string using FMT, pattern: %m%n/threads:6 | +1.4849 | +0.5792 | 696 | 1729| | Appending int value using FMT, pattern: %m%n | +1.1461 | +1.1461 | 421 | 903| | Appending int value using FMT, pattern: %m%n/threads:6 | +1.5843 | +0.6148 | 678 | 1753| | Appending int+float using FMT, pattern: %m%n | +0.9075 | +0.9076 | 548 | 1046| | Appending int+float using FMT, pattern: %m%n/threads:6 | +1.2775 | +0.3857 | 785 | 1789| | Appending int+10float using FMT, pattern: %m%n | +0.2787 | +0.2787 | 1779 | 2275| | Appending int+10float using FMT, pattern: %m%n/threads:6 | +0.6015 | +0.2497 | 1270 | 2034| | Async, Sending int+10float using FMT and AsyncBuffer | +0.0093 | +0.0093 | 768 | 775| | Async, Sending int+10float using FMT and AsyncBuffer/threads:6 | +0.0115 | +0.0092 | 1601 | 1620| | Async, Sending int+10float using operator<< and AsyncBuffer | +0.0048 | +0.0048 | 1344 | 1351| | Async, Sending int+10float using operator<< and AsyncBuffer/threads:6 | -0.0257 | -0.0283 | 1657 | 1615| | Logging int+float using MessageBuffer, pattern: %d %m%n | +0.4026 | +0.4042 | 1216 | 1706| | Logging int+float using MessageBuffer, pattern: %d %m%n/threads:6 | +0.6030 | +0.1085 | 1835 | 2942| | Logging int+float using MessageBuffer, JSON | +0.0740 | +0.0739 | 5505 | 5912| | Logging int+float using MessageBuffer, JSON/threads:6 | -0.3340 | -0.2294 | 8276 | 5512| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
