FreeAndNil opened a new pull request, #318:
URL: https://github.com/apache/logging-log4net/pull/318
Two findings on `TelnetAppender`, both about what a connected client can do
to
the host application rather than to the log.
- **f012** The appender streams the log to any client that connects,
unauthenticated, and defaulted to every interface on port 23. It now
defaults
to `127.0.0.1`; remote access is opt-in via `listenAddress`. Every
documented
example already used loopback.
- **f014** Clients were written to serially under the appender lock, so one
that
stopped reading held up every thread that logs for `sendTimeoutMillis`.
Writes
go through a background thread now, bounded by `sendQueueSize` (500), with
a
logging call waiting at most `enqueueTimeoutMillis` (50) for room.
Both change behaviour and need release notes:
- Relying on the implicit all-interfaces bind loses remote access until
`listenAddress` is set.
- Telnet delivery is asynchronous and drops under load, never the log. While
the
queue stays full, `enqueueTimeoutMillis` caps logging at 20 events/s; set
it to 0
to drop immediately instead of waiting.
A third commit merges three copies of `RecordingErrorHandler` in the tests
into
one helper, which is what the f014 test needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
