ramanathan1504 commented on PR #4271:
URL: https://github.com/apache/logging-log4j2/pull/4271#issuecomment-5574018672
@ppkarwasz
The `MarshalledObject` removal is complete. Deleting `serializedEvent.dat`
is fine too. `SerializedLayoutTest.testDeserialization` calls
`testSerialization()` first, and that
rewrites the file before reading it.
The write side stopped degrading though. A `Message` holding a
non-serializable field used to be caught by `marshall` and replaced by
`messageString`. Now it throws
`java.io.NotSerializableException` out of the whole event.
`SerializedLayout.toByteArray` catches that, logs it, and still returns the
buffer. So a truncated record goes on
the wire where a degraded one used to. Left a fix inline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
