ppkarwasz commented on PR #4271: URL: https://github.com/apache/logging-log4j2/pull/4271#issuecomment-5896395855
> And nothing tests the new behaviour. Neither the filtered nested read nor the fallback to `SimpleMessage` is covered. The regenerated base64 fixture passes either way, even with an unfiltered nested stream. You are completely right on this one too. Since we want to be *neutral* regarding serialization, it makes sense to rethrow exceptions that come from corrupted data to the reader, more precisely: 1. If deserialization failed due to a missing class (e.g. custom `Message` implementation), we degrade to `SimpleMessage` first and `null` as a fallback. 2. If deserialization failed due to an `IOException` in the stream, we rethrow. Fixed in 9270577a837d0fa1b06231537d2a03e91617f28e -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
