ppkarwasz commented on code in PR #4365:
URL: https://github.com/apache/logging-log4j2/pull/4365#discussion_r4138089105
##########
log4j-api-test/src/test/java/org/apache/logging/log4j/util/internal/SerializationUtilTest.java:
##########
@@ -51,4 +60,30 @@ void stripArrayClass(final Class<?> arrayClass, final
Class<?> componentClazz) {
void stripArrayString(final Class<?> arrayClass, final Class<?>
componentClazz) {
assertThat(SerializationUtil.stripArray(arrayClass.getName())).isEqualTo(componentClazz.getName());
}
+
+ static final class Payload implements Serializable {
+ private static final long serialVersionUID = 1L;
+ }
+
+ @Test
+ @EnabledForJreRange(min = JRE.JAVA_9)
+ void readWrappedObjectUsesObjectInputFilterOfOuterStream() throws
Exception {
+ final ByteArrayOutputStream bout = new ByteArrayOutputStream();
+ try (final ObjectOutputStream out = new ObjectOutputStream(bout)) {
+ out.writeObject(new ObjectMessage(new Payload()));
+ }
+ final byte[] data = bout.toByteArray();
+
+ final ObjectInputStream unfiltered = new ObjectInputStream(new
ByteArrayInputStream(data));
+ assertThat(((ObjectMessage)
unfiltered.readObject()).getParameter()).isInstanceOf(Payload.class);
+
+ // Java 9 API accessed through reflection, since this module targets
Java 8
+ final Class<?> filterClass =
Class.forName("java.io.ObjectInputFilter");
+ final Object filter = Class.forName("java.io.ObjectInputFilter$Config")
+ .getMethod("createFilter", String.class)
+ .invoke(null, "!" + Payload.class.getName());
+ final ObjectInputStream filtered = new ObjectInputStream(new
ByteArrayInputStream(data));
+ ObjectInputStream.class.getMethod("setObjectInputFilter",
filterClass).invoke(filtered, filter);
+ assertThat(((ObjectMessage)
filtered.readObject()).getParameter()).isNull();
Review Comment:
Thanks, I fixed it in
https://github.com/apache/logging-log4j2/pull/4365/commits/d2705729b6a114f0f0ff3c70b30d17e023bfd85d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
