rm5248 commented on code in PR #788: URL: https://github.com/apache/logging-log4cxx/pull/788#discussion_r4343176909
########## src/examples/cpp/MyApp/CMakeLists.txt: ########## @@ -17,6 +17,9 @@ cmake_minimum_required(VERSION 3.13) project(MyApp LANGUAGES CXX) +# Ensure Log4cxx does not throw any warnings when used +set(CMAKE_COMPILE_WARNING_AS_ERROR ON) Review Comment: It doesn't look like this will _enable_ specific warnings, I think we need to do that ourselves. Google AI claims that `/W4` for MSVC and `-Wall -Wextra` for GCC are equivalent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
