FreeAndNil commented on PR #339: URL: https://github.com/apache/logging-log4net/pull/339#issuecomment-6426276337
Thanks @dajiaohuang, the bug is real and your fix is right. We reshaped it a little before merging: - one guard instead of two: the static name check from #334 now also covers a name without dates - the test moved to `RollingFileAppenderTest`, next to the other `InitializeRollBackups` tests, and calls it directly, so it needs no subclass and no temp folder - a positive case: `log.txt.5` still counts as backup 5 - a changelog entry Here is the commit on top of your branch: https://github.com/apache/logging-log4net/commit/2fbda3d484d2cca5ef249fea479c0aae61108548 Could you pull it into your branch and push? It applies without conflicts, and we squash when merging the PR. ``` git switch fix/338-prefix-sibling-size-backup git pull https://github.com/apache/logging-log4net.git Feature/338-size-backup-prefix-sibling git push ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
