ramanathan1504 commented on code in PR #4433: URL: https://github.com/apache/logging-log4j2/pull/4433#discussion_r4397183365
########## src/changelog/.3.x.x/4433_logger_config.xml: ########## @@ -0,0 +1,14 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns="https://logging.apache.org/xml/ns"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation=" + https://logging.apache.org/xml/ns + https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"; + type="fixed"> + <description format="asciidoc"> + 1. Adds back the LoggerConfig constructor used by Spring Boot. + 2. Fix LoggerUpdaterTest: + * testUpdateLoggersPropertyListeners: it now keeps a reference to its configuration-started listener and removes it in a finally block. + * propertyChangeListenerReceivesOldAndNewConfigurationOnReconfiguration: in a finally block, it now removes its property-change listener and calls context.reconfigure(). + </description> Review Comment: ```suggestion <issue id="4433" link="https://github.com/apache/logging-log4j2/pull/4433"/> <description format="asciidoc"> Restore the `LoggerConfig(String, Level, boolean)` constructor. </description> ``` The entry should say what the user sees, in one line as per my understanding if really these need i fine too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
