rgoers commented on code in PR #4433:
URL: https://github.com/apache/logging-log4j2/pull/4433#discussion_r4391884887


##########
log4j-core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java:
##########
@@ -201,6 +201,19 @@ public B asBuilder() {
         }
     }
 
+    /**
+     * Constructor that sets the name, level and additive values.
+     * @deprecated - For comapatibilty with 2.x.
+     *
+     * @param name The Logger name.
+     * @param level The Level.
+     * @param additive true if the Logger is additive, false otherwise.
+     */
+    @Deprecated
+    public LoggerConfig(final String name, final Level level, final boolean 
additive) {

Review Comment:
   I am noticing that in 2.x the constructor that takes a Configuration 
parameter does not validate that it is non-null and could also throw an NPE. 
The reason this constructor does not throw an NPE in 2.x is that it does not 
delegate. I will need to determine if this needs to do the same.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to